ensure get returns a nil and key not found as per spec #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
commented
Oct 11, 2021
| @@ -333,6 +333,18 @@ func keyValid(key string) bool { | |||
|
|
|||
| // Get returns the latest value for the key. | |||
| func (kv *kvs) Get(key string) (KeyValueEntry, error) { | |||
| e, err := kv.get(key) | |||
| if err == ErrKeyDeleted { | |||
| return nil, ErrKeyNotFound | |||
There was a problem hiding this comment.
It's critical that from the perspective of a user of Get() its always found/not found when delete or purge operation, we also discussed returning half baked Entries and agreed to return nil instead.
However we use the invalid behavior of the previous get operation in later functions in Create(), so I retained old behavior for internal use in get() but made Get() comply with spec
There was a problem hiding this comment.
Since ErrKeyDeleted is now internal only maybe I should unexport it
derekcollison
approved these changes
Oct 11, 2021
ripienaar
force-pushed
the
get_nil_not_found
branch
from
fc261d7
to
7cac399
Compare
|
updated for |
Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar
force-pushed
the
get_nil_not_found
branch
from
7cac399
to
d7eb0d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: R.I.Pienaar rip@devco.net